This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
disable error checking when building old versions #13725
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +122,8 @@ function checkout () { | |||
| git pull | |||
| # master gets warnings as errors for Sphinx builds | |||
| OPTS="-W" | |||
| else | |||
There was a problem hiding this comment.
OPTS is already empty (set at line 47). Why is this required? If tag is master OPTS is set to "-w" otherwise it is left as is which is empty.
There was a problem hiding this comment.
Once master gets called OPTS is set, but when another version is called it should be unset.
sandeep-krishnamurthy
approved these changes
Dec 29, 2018
sandeep-krishnamurthy
added
the
pr-awaiting-merge
rondogency
pushed a commit
to rondogency/incubator-mxnet
that referenced
this pull request
Jan 9, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the options settings for the docs build for the website publishing job in CI. If you ran master first the error checking would get turned on and then never turn off for the older versions.
Testing
This will fail now:
./build_all_version.sh "master;v1.3.x" "master;1.3.1"
So the workaround is to run master last, but with this PR, it will work generating different versions in any order.